Fix "histogram" feature to be all_series rather than all_elements#645
Closed
fotonick wants to merge 207 commits intoplotters-rs:next-release-develfrom
Closed
Fix "histogram" feature to be all_series rather than all_elements#645fotonick wants to merge 207 commits intoplotters-rs:next-release-develfrom
fotonick wants to merge 207 commits intoplotters-rs:next-release-develfrom
Conversation
Add `ab_glyph` font backend
Updates the requirements on [criterion](https://github.com/bheisler/criterion.rs) to permit the latest version. - [Release notes](https://github.com/bheisler/criterion.rs/releases) - [Changelog](https://github.com/bheisler/criterion.rs/blob/master/CHANGELOG.md) - [Commits](bheisler/criterion.rs@0.3.6...0.4.0) --- updated-dependencies: - dependency-name: criterion dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
…criterion-0.4.0 Update criterion requirement from 0.3.6 to 0.4.0
Updates the requirements on [ttf-parser](https://github.com/RazrFalcon/ttf-parser) to permit the latest version. - [Release notes](https://github.com/RazrFalcon/ttf-parser/releases) - [Changelog](https://github.com/RazrFalcon/ttf-parser/blob/master/CHANGELOG.md) - [Commits](harfbuzz/ttf-parser@v0.15.0...v0.17.0) --- updated-dependencies: - dependency-name: ttf-parser dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Aaron Erhardt <[email protected]>
Export the `doc` macro, to use of `define_color`
…ttf-parser-0.17.0 Update ttf-parser requirement from 0.15.0 to 0.17.0
update font backend documentation
Signed-off-by: Aaron Erhardt <[email protected]>
Signed-off-by: Aaron Erhardt <[email protected]>
doc-comment grammar fixups
Bump font-kit to latest
plotters: update chrono dependency to 0.4.32
wasm-bindgen 0.2.62 is not compatible with a wasm ABI change that rustc wishes to enable by default for wasm32-unknown-unknown, currently gated behind passing the -Zwasm-c-abi flag to rustc. wasm-bindgen 0.2.89 should exhibit seamless behavior before and after the ABI change to match the C ABI, so depend on that.
Relax too strict life times on ChartBuilder
…en-0.2.89 plotters: Depend on wasm-bindgen 0.2.89 or higher
Apply most clippy lints
…vg-reduce-allocations update svg backend code to write all data directly into output buffer
Fix backend example in README
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 1 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v1...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…_actions/actions/upload-artifact-4 Bump actions/upload-artifact from 1 to 4
Bumps [actions/checkout](https://github.com/actions/checkout) from 1 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v1...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1 to 3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v1...v3) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…_actions/actions/checkout-4 Bump actions/checkout from 1 to 4
…_actions/github/codeql-action-3 Bump github/codeql-action from 1 to 3
Derive `Clone` impl for ranged combinators
Member
|
Same here, that could potentially break the code of a user, so I'm not going to merge this into main. I hope you understand. |
Author
|
Oy, I tried the Github feature of changing the merge target, but it's all a garbled mess now. Will close now and reopen when I've properly rebased to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the
histogramfeature was bundled withall_elements, when it should beall_series, so I fixed it. I don't see any tests or CI configurations that would change based on this. With this patch on a local repo, I tested that one can update the histogram example in plotters-doc-data/evcxr-jupyter-integration.ipynb to remove theall_elementsfeature and start working correctly.Tests pass. Benchmarks unchanged. Doc formatting doesn't change. WASM untested due to broken link to instructions (#644), but it shouldn't change at all.